Skip to content

Enable strict param on base64_decode and array_search#3806

Merged
MGatner merged 2 commits intocodeigniter4:developfrom
paulbalandan:strict-params
Oct 24, 2020
Merged

Enable strict param on base64_decode and array_search#3806
MGatner merged 2 commits intocodeigniter4:developfrom
paulbalandan:strict-params

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

Description
This continues on #3799 to add true param to base64_decode and array_search, which are used in the framework. This does not change yet other functions that can be made strict (e.g., array_keys, mb_detect_encoding) as it is not yet used.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Copy Markdown
Member

@paulbalandan please update code sample before and after in :

			new CodeSample(
				<<<'CODE_SAMPLE'
in_array('a', $array);
CODE_SAMPLE
,
				<<<'CODE_SAMPLE'
in_array('a', $array, true);
CODE_SAMPLE
			),

in getDefinition() function.

@MGatner MGatner merged commit 725b008 into codeigniter4:develop Oct 24, 2020
@paulbalandan paulbalandan deleted the strict-params branch October 24, 2020 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants